Add closing notice to homepage UI#638
Open
ukane-philemon wants to merge 1 commit intodecred:masterfrom
Open
Conversation
Member
|
Hi @ukane-philemon, This is good work, but unfortunately we don't plan to release any new versions of dcrstakepool so this change is unlikely to ever be deployed by operators. I will revierw and we can get it merged regardless, just in case somebody does find it useful at some point. |
jholdstock
requested changes
Jan 2, 2022
ukane-philemon
force-pushed
the
AddClosingNoticeToHomePageUI
branch
from
87e4755 to
6b4a5c2
Compare
jholdstock
approved these changes
Jan 13, 2022
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incentivize and facilitate the migration from dcrstakepool to vspd by informing dcrstakepool users about it on the front page.
This includes three items:
dcrstakepool operator can set the link to their vspd and tweak banner text (specify a closing message). However, the closing notice is only shown if the dcrstakepool operator is closed.
Pictures below:
Before:
After(If link to new vsp server is set):
After(If link to new vsp is not set):
After(If custom message is not specified and new vsp not set):
Closes #635